Skip to content

Remove unused methods#140222

Merged
joshua-adams-1 merged 4 commits intomainfrom
remove-unused-tv-methods
Jan 9, 2026
Merged

Remove unused methods#140222
joshua-adams-1 merged 4 commits intomainfrom
remove-unused-tv-methods

Conversation

@joshua-adams-1
Copy link
Copy Markdown
Contributor

@joshua-adams-1 joshua-adams-1 commented Jan 6, 2026

Removes unused methods from TransportVersionUtils and TransformConfigVersionUtils

@joshua-adams-1
Remove unused methods
80c8fad 
Removes unused methods from TransportVersionUtils and TransformConfigVersionUtils
@joshua-adams-1 joshua-adams-1 self-assigned this Jan 6, 2026
@joshua-adams-1 joshua-adams-1 marked this pull request as ready for review January 7, 2026 16:05
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. label Jan 7, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jan 7, 2026

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@DaveCTurner DaveCTurner requested a review from a team January 7, 2026 16:16
@DaveCTurner
Copy link
Copy Markdown
Member

DaveCTurner commented Jan 7, 2026

Going to ask core/infra whether there's any reason to keep these (e.g. some test suite external to this repo that uses them?)

@DaveCTurner DaveCTurner mentioned this pull request Jan 7, 2026
Merged
mark-vieira
mark-vieira approved these changes Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have any input on MlConfigVersionUtils or TransformConfigVersionUtils. I'll leave that to the ML folks, but changes to TransportVersionUtils LGTM.

test/framework/src/main/java/org/elasticsearch/test/TransportVersionUtils.java
}

/** Returns the oldest known {@link TransportVersion} */
public static TransportVersion getFirstVersion() {
Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should go. @jdconrad and I already discussed this. In every case what people want is TransportVersion.minimumCompatible().

@joshua-adams-1
Copy link
Copy Markdown
Contributor Author

joshua-adams-1 commented Jan 8, 2026

some test suite external to this repo that uses them

For future reference then, what repos use code inside ElasticSearch that I should be aware of? Ie if I see another unused method I'd like to check everywhere first before removing and this would save me making a mistake

@mark-vieira
Copy link
Copy Markdown
Contributor

mark-vieira commented Jan 8, 2026

some test suite external to this repo that uses them

For future reference then, what repos use code inside ElasticSearch that I should be aware of? Ie if I see another unused method I'd like to check everywhere first before removing and this would save me making a mistake

It would only be serverless and we test that as part of pull requests so if CI passes here it should be safe to remove.

DaveCTurner
DaveCTurner approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's go for it then LGTM

@joshua-adams-1 joshua-adams-1 merged commit 78013b7 into main Jan 9, 2026
36 checks passed
@joshua-adams-1 joshua-adams-1 deleted the remove-unused-tv-methods branch January 9, 2026 11:30
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 9, 2026
@szybia
Merge remote-tracking branch 'upstream/main' into reindex-cancel-api
63adb15 
* upstream/main: (76 commits)
  [Inference API] Get _services skips EIS authorization call if CCM is not configured (elastic#139964)
  Improve TSDB codec benchmarks with full encoder and compression metrics (elastic#140299)
  ESQL: Consolidate test `BlockLoaderContext`s (elastic#140403)
  ESQL: Improve Lookup Join performance with CachedDirectoryReader (elastic#139314)
  ES|QL: Add more examples for the match operator (elastic#139815)
  ESQL: Add timezone to add and sub operators, and ConfigurationAware planning support (elastic#140101)
  ESQL: Updated ToIp tests and generated documentation for map parameters (elastic#139994)
  Disable _delete_by_query and _update_by_query for CCS/stateful (elastic#140301)
  Remove unused method ElasticInferenceService.translateToChunkedResults (elastic#140442)
  logging hot threads on large queue of the management threadpool (elastic#140251)
  Search functions docs cleanup (elastic#140435)
  Unmute 350_point_in_time/point-in-time with index filter (elastic#140443)
  Remove unused methods (elastic#140222)
  Add CPS and `project_routing` support for `_mvt` (elastic#140053)
  Streamline `ShardDeleteResults` collection (elastic#140363)
  Fix Docker build to use --load for single-platform images (elastic#140402)
  Parametrize + test VectorScorerOSQBenchmark (elastic#140354)
  `RecyclerBytesStreamOutput` using absolute offsets (elastic#140303)
  Define bulk float native methods for vector scoring (elastic#139885)
  Make `TimeSeriesAggregate` `TimestampAware` (elastic#140270)
  ...
jimczi pushed a commit to jimczi/elasticsearch that referenced this pull request Jan 12, 2026
@joshua-adams-1 @jimczi
Remove unused methods (elastic#140222)
669277c 
Removes unused methods from TransportVersionUtils and TransformConfigVersionUtils
@repantis repantis added :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Distributed Coordination/Distributed labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@joshua-adams-1 joshua-adams-1

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshua-adams-1 @elasticsearchmachine @DaveCTurner @mark-vieira @repantis